cstamas commented on PR #1771: URL: https://github.com/apache/maven-resolver/pull/1771#issuecomment-3811649797
I am for exposing (what is related to that in this PR), but I am -1 on `canHandle(String)` method as I find it flawed. Remember, that RemoteRepository, while it has getProtocol() is waay lax interpreted, and is not strict. Many times it cannot be told even what proto is... See https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/test/java/org/eclipse/aether/repository/RemoteRepositoryTest.java but also https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/repository/RepositoryUriUtils.java So `""` (empty string) proto is completely valid.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
