Copilot commented on code in PR #361:
URL: 
https://github.com/apache/maven-shared-utils/pull/361#discussion_r2751210438


##########
src/main/java/org/apache/maven/shared/utils/StringUtils.java:
##########
@@ -553,7 +553,9 @@ public static String[] split(@Nonnull String str, @Nullable 
String separator, in
      *
      * @param array the array of values to concatenate.
      * @return the concatenated string.
+     * @deprecated use <code>java.lang.String.join(</code>) instead
      */
+    @Deprecated
     @Nonnull
     public static String concatenate(@Nonnull Object... array) {

Review Comment:
   The PR description states "fixes #349", but issue #349 is titled "Deprecate 
StringUtils.clean" and describes the clean method, not the concatenate method 
being deprecated here. The clean method is already deprecated (line 74-76 of 
this file). This appears to be a mismatch between the PR description and the 
actual changes. Please verify whether this PR should reference a different 
issue, or if the PR description needs to be corrected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to