rmannibucau commented on code in PR #1027:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1027#discussion_r2755055235
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -885,6 +885,16 @@ final void
amendincrementalCompilation(EnumSet<IncrementalBuild.Aspect> aspects,
@Parameter(property = "maven.compiler.maxmem")
protected String maxmem;
+ /**
+ * Should maven log a summary of compiler messages (if any) by type.
+ * When there are a lot of messages of the same type (unchecked,
deprecation etc),
+ * it can make the output more readable.
+ *
+ * @since 4.0.0-beta-5
+ */
+ @Parameter(property = "maven.compiler.messageLogType", defaultValue =
"COMPILER")
+ protected MessageLogType messageLogType;
+
Review Comment:
filtering for a logger is only the level which doesn't apply well at all
there
agree "formatting" is poor from a semantic point of view but still, it
doesn't match logger design
also think we should stick to logger=class until we abuse MDC globally which
is not needed there and would require a lot of rework
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
