jbliznak commented on code in PR #3252: URL: https://github.com/apache/maven-surefire/pull/3252#discussion_r2766627969
########## surefire-booter/src/test/java/org/apache/maven/surefire/booter/ProcessHandleCheckerTest.java: ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.surefire.booter; + +import java.lang.management.ManagementFactory; + +import org.junit.Test; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.junit.Assume.assumeTrue; + +/** + * Tests for {@link ProcessHandleChecker}. + * <p> + * These tests use reflection-based PID detection to work on both Java 8 and Java 9+. + */ +public class ProcessHandleCheckerTest { + + @Test + public void shouldReportAvailableOnJava9Plus() { + // This test runs on modern JVMs, so isAvailable() should return true + assertThat(ProcessHandleChecker.isAvailable()).isTrue(); Review Comment: what about checking current Java version instead (when the test name actually says that) something like ```suggestion double v = Double.parseDouble(System.getProperty("java.specification.version")); Assert.assertEquals(v >= 9.0, ProcessHandleChecker.isAvailable()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
