anukalp2804 commented on code in PR #11576:
URL: https://github.com/apache/maven/pull/11576#discussion_r2769953239
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -61,41 +61,76 @@ public interface XmlNode {
@Deprecated(since = "4.0.0", forRemoval = true)
String CHILDREN_COMBINATION_MODE_ATTRIBUTE =
XmlService.CHILDREN_COMBINATION_MODE_ATTRIBUTE;
+ /**
+ * @deprecated since 4.0.0.
Review Comment:
Thanks for pointing that out. I’ve removed the redundant “since 4.0.0.” text
from the comment and kept the version in the annotation only.
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -54,48 +54,85 @@
@Immutable
public interface XmlNode {
+ /**
+ * @deprecated Use {@link XmlService#CHILDREN_COMBINATION_MODE_ATTRIBUTE}
instead.
+ */
+ @Deprecated(since = "4.0.0", forRemoval = true)
+ String CHILDREN_COMBINATION_MODE_ATTRIBUTE =
XmlService.CHILDREN_COMBINATION_MODE_ATTRIBUTE;
+
/**
* @deprecated since 4.0.0.
- * Use {@link XmlService#CHILDREN_COMBINATION_MODE_ATTRIBUTE}
instead.
+ * Use {@link XmlService#CHILDREN_COMBINATION_MERGE} instead.
*/
@Deprecated(since = "4.0.0", forRemoval = true)
String CHILDREN_COMBINATION_MODE_ATTRIBUTE =
XmlService.CHILDREN_COMBINATION_MODE_ATTRIBUTE;
@Deprecated(since = "4.0.0", forRemoval = true)
String CHILDREN_COMBINATION_MERGE = XmlService.CHILDREN_COMBINATION_MERGE;
+
+ /**
+ * @deprecated since 4.0.0.
Review Comment:
Thanks for pointing that out. I’ve removed the redundant “since 4.0.0.” text
from the comment and kept the version in the annotation only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
