slawekjaranowski commented on code in PR #3252:
URL: https://github.com/apache/maven-surefire/pull/3252#discussion_r2777353086
##########
.github/workflows/maven-verify.yml:
##########
@@ -49,4 +49,9 @@ jobs:
!**/hs_err_pid*
!surefire-its/target/ConsoleOutputIT_*/target/surefire-reports/*-jvmRun*-events.bin
timeout-minutes: 600
- os-matrix: '[ "ubuntu-latest", "windows-2022", "macos-latest" ]'
+ os-matrix: '[ "ubuntu-latest", "windows-2022", "windows-latest",
"macos-latest" ]'
+ # exclude jkd 8 on windows-latest wmc process not here anymore and jdk8
not supporting processhandle
Review Comment:
if you add `windows-2022` and `windows-latest` to global matrix with one
exclude, we will have executed
```
windows-2022 - jdk8, jdk11, jdk17, jdk21
windows-latest - jdk11, jdk17, jdk21
```
so will be a 7 builds for windows
with my proposition we will have:
```
windows-2022 - jdk8
windows-latest - jdk11, jdk17, jdk21
```
4 builds
I'm not sure if we need such many windows builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
