desruisseaux commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2777394451
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -906,15 +906,17 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
}
/**
- * Warns about legacy directory usage in a modular project. Two cases
are handled:
+ * Fails the build if a legacy directory is present in a modular
project.
+ * <p>
+ * "Present" means either:
* <ul>
- * <li>Case 1: The default legacy directory exists on the filesystem
(e.g., src/main/java exists)</li>
- * <li>Case 2: An explicit legacy directory is configured that
differs from the default</li>
+ * <li><b>Configuration presence</b>: an explicit configuration
differs from the default</li>
+ * <li><b>Physical presence</b>: the default directory exists on the
filesystem</li>
* </ul>
- * Legacy directories are unconditionally ignored in modular projects
because it is not clear
- * how to dispatch their content between different modules.
+ * In both cases, the legacy directory conflicts with modular sources
and must not be used.
Review Comment:
> not "and must not be used" but rather the complete build fails.
Isn't what the next line below is saying?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
