desruisseaux commented on code in PR #1017:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1017#discussion_r2777407258
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1185,8 +1185,17 @@ public void execute() throws MojoException {
supportedVersion = version;
}
}
+
Options configuration = parseParameters(compiler);
try {
+ // --- Fix for issue #1006: ensure <proc>only</proc> runs
annotation processors
+ // ---
+ if ("only".equalsIgnoreCase(compilerConfiguration.getProc())) {
+ logger.info("Running annotation processors (proc: only)");
+ compile(compiler, configuration);
+ return;
+ }
+ //
-------------------------------------------------------------------------------
Review Comment:
Just looking for the first time at this pull request seriously (my previous
comment was only formatting). What is the purpose of this addition? It does
exactly the same thing as before — just invoking `compiler(compiler,
configuration)` — with only a log added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
