desruisseaux commented on PR #11639:
URL: https://github.com/apache/maven/pull/11639#issuecomment-3864732484
* Rebased the pull request.
* Extracted in a new `ModuleSourcesHelper` class some codes shared by
`SourceHandlingContext` and this pull request.
* Made the existing tests a little bit more exhaustive and reduced code
duplication.
* Added a new test for the multi-module case.
* Remove the `<build>` element only if `preserve.model.version` is `false`.
* In this case, the `<build>` element may be removed also for non-modular
projects if they use the `<sources>` element, for the same reason as for
modular-project: this is not a valid 4.0.0 model.
* Classical Maven projects which use the legacy way to declare sources
stay unimpacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
