desruisseaux commented on code in PR #1022:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1022#discussion_r2777888531
##########
src/main/java/org/apache/maven/plugin/compiler/Options.java:
##########
@@ -320,13 +320,13 @@ private boolean checkNumberOfArguments(String option, int
count, boolean immedia
if (expected == count) {
warning = null;
return true;
- } else if (expected < 1) {
+ } else if (expected == 0) {
Review Comment:
> So if expected == 0 do we still need to check if checker instanceof
ForkedCompiler?
No, `ForkedCompiler` unconditionally returns -1 because it has no
information about which options are supported by external tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
