slawekjaranowski commented on code in PR #156:
URL: https://github.com/apache/maven-dist-tool/pull/156#discussion_r2780094688
##########
pom.xml:
##########
@@ -57,11 +57,13 @@
</ciManagement>
<properties>
+ <!-- This variable needs to be overwritten, as it is used in the Enforce
Bytecode Version rule -->
+ <javaVersion>21</javaVersion>
<project.build.outputTimestamp>x</project.build.outputTimestamp>
<netbeans.checkstyle.format>true</netbeans.checkstyle.format>
<mvnversion>3.9.12</mvnversion>
- <maven.compiler.target>21</maven.compiler.target>
- <minimalJavaBuildVersion>21</minimalJavaBuildVersion>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
Review Comment:
It should be set by parent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
