elharo commented on code in PR #369:
URL:
https://github.com/apache/maven-shared-utils/pull/369#discussion_r2787920695
##########
src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java:
##########
@@ -104,14 +94,7 @@ String[] getShellArgs() {
}
protected String quoteOneItem(String inputString, boolean isExecutable) {
- char[] escapeChars = getEscapeChars(isSingleQuotedExecutableEscaped(),
isDoubleQuotedExecutableEscaped());
- return StringUtils.quoteAndEscape(
- inputString,
- isExecutable ? getExecutableQuoteDelimiter() :
getArgumentQuoteDelimiter(),
- escapeChars,
- getQuotingTriggerChars(),
- '\\',
- unconditionalQuoting);
+ return inputString;
Review Comment:
copilot missed that getEscapeChars always returned an empty list so nothing
was ever escaped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
