olamy commented on code in PR #3259:
URL: https://github.com/apache/maven-surefire/pull/3259#discussion_r2791469591
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -2998,7 +3007,9 @@ public boolean isApplicable() {
}
@Override
- public void addProviderProperties() {}
+ public void addProviderProperties() {
Review Comment:
ditto.
same comment. Junit3 will be still supported. vintage engine will be added
magically same as provider is added magically in versions previous the big
change.
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -3290,6 +3303,7 @@ public void addProviderProperties() throws
MojoExecutionException {
convertJunitCoreParameters();
convertGroupParameters();
convertJunitEngineParameters();
+ providerDeprecationWarning("JUnit4 provider is deprecated, will be
removed in future versions of plugin.");
Review Comment:
ditto.
same comment. Junit4 will be still supported. vintage engine will be added
magically same as provider is added magically in versions previous the big
change.
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -3039,7 +3050,9 @@ public boolean isApplicable() {
}
@Override
- public void addProviderProperties() {}
+ public void addProviderProperties() {
Review Comment:
ditto.
same comment. Junit4 will be still supported. vintage engine will be added
magically same as provider is added magically in versions previous the big
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
