kwin commented on code in PR #1792: URL: https://github.com/apache/maven-resolver/pull/1792#discussion_r2791739598
########## src/site/markdown/transporter-known-issues.md: ########## @@ -0,0 +1,51 @@ +# Transporter Known Issues +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +This page lists known issues related to various transports. Review Comment: ```suggestion This page lists known issues related to various transporters. ``` ########## src/site/markdown/transporter-known-issues.md: ########## @@ -0,0 +1,51 @@ +# Transporter Known Issues +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +This page lists known issues related to various transports. + +## The `jdk` (Java HttpClient) Transport Review Comment: ```suggestion ## The `jdk` (Java HttpClient) Transporter ``` ########## src/site/markdown/transporter-known-issues.md: ########## @@ -0,0 +1,51 @@ +# Transporter Known Issues +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +This page lists known issues related to various transports. + +## The `jdk` (Java HttpClient) Transport + +Given this transporter uses the Java HttpClient (available since Java 11), it is in user best interest +to use latest patch version of Java, as HttpClient is getting bugfixes regularly. + +Known issues: +* Does not properly support `aether.transport.http.requestTimeout` configuration prior Java 26, see [JDK-8208693](https://bugs.openjdk.org/browse/JDK-8208693) +* No TLS Proxy support, see [here](https://dev.to/kdrakon/httpclient-can-t-connect-to-a-tls-proxy-118a) Review Comment: ```suggestion * No TLS Proxy support, see [here](https://dev.to/kdrakon/httpclient-can-t-connect-to-a-tls-proxy-118a) * No SOCKS proxy support, see [JDK-8214516](https://bugs.openjdk.org/browse/JDK-8214516) ``` ########## src/site/markdown/transporter-known-issues.md: ########## @@ -0,0 +1,51 @@ +# Transporter Known Issues +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +This page lists known issues related to various transports. + +## The `jdk` (Java HttpClient) Transport + +Given this transporter uses the Java HttpClient (available since Java 11), it is in user best interest +to use latest patch version of Java, as HttpClient is getting bugfixes regularly. + +Known issues: +* Does not properly support `aether.transport.http.requestTimeout` configuration prior Java 26, see [JDK-8208693](https://bugs.openjdk.org/browse/JDK-8208693) +* No TLS Proxy support, see [here](https://dev.to/kdrakon/httpclient-can-t-connect-to-a-tls-proxy-118a) +* In case of Proxy TLS tunneling, to enable Proxy Basic authentication, one must use `jdk.http.auth.tunneling.disabledScheme` + Java System Property, see [here](https://docs.oracle.com/en/java/javase/21/core/java-networking.html#GUID-801380C1-4300-4ED8-A390-3C39135267CD). Java versions since 8u111 have this property set to value "Basic" making HTTP + Basic authentication disabled, see [here](https://www.oracle.com/java/technologies/javase/8u111-relnotes.html). To + enable HTTP Basic authentication for Proxy TLS tunneling, one must set `jdk.http.auth.tunneling.disabledScheme` to + empty string, e.g. by adding `-Djdk.http.auth.tunneling.disabledScheme=""` JVM argument. + +Maven 4 uses this transport by default for HTTP(S) protocol. + +## The `apache` (Apache HttpClient) Transport Review Comment: ```suggestion ## The `apache` (Apache HttpClient) Transporter ``` ########## src/site/markdown/transporter-known-issues.md: ########## @@ -0,0 +1,51 @@ +# Transporter Known Issues +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +This page lists known issues related to various transports. + +## The `jdk` (Java HttpClient) Transport + +Given this transporter uses the Java HttpClient (available since Java 11), it is in user best interest +to use latest patch version of Java, as HttpClient is getting bugfixes regularly. + +Known issues: +* Does not properly support `aether.transport.http.requestTimeout` configuration prior Java 26, see [JDK-8208693](https://bugs.openjdk.org/browse/JDK-8208693) +* No TLS Proxy support, see [here](https://dev.to/kdrakon/httpclient-can-t-connect-to-a-tls-proxy-118a) +* In case of Proxy TLS tunneling, to enable Proxy Basic authentication, one must use `jdk.http.auth.tunneling.disabledScheme` + Java System Property, see [here](https://docs.oracle.com/en/java/javase/21/core/java-networking.html#GUID-801380C1-4300-4ED8-A390-3C39135267CD). Java versions since 8u111 have this property set to value "Basic" making HTTP + Basic authentication disabled, see [here](https://www.oracle.com/java/technologies/javase/8u111-relnotes.html). To + enable HTTP Basic authentication for Proxy TLS tunneling, one must set `jdk.http.auth.tunneling.disabledScheme` to + empty string, e.g. by adding `-Djdk.http.auth.tunneling.disabledScheme=""` JVM argument. + +Maven 4 uses this transport by default for HTTP(S) protocol. + +## The `apache` (Apache HttpClient) Transport + +Transporter based on Apache HttpClient. + +To use this transporter in Maven 4, you need to specify `-Dmaven.resolver.transport=apache` user property. + +## The `jetty` (Jetty HttpClient) Transport Review Comment: ```suggestion ## The `jetty` (Jetty HttpClient) Transporter ``` ########## src/site/markdown/transporter-known-issues.md: ########## @@ -0,0 +1,51 @@ +# Transporter Known Issues +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +This page lists known issues related to various transports. + +## The `jdk` (Java HttpClient) Transport + +Given this transporter uses the Java HttpClient (available since Java 11), it is in user best interest +to use latest patch version of Java, as HttpClient is getting bugfixes regularly. + +Known issues: +* Does not properly support `aether.transport.http.requestTimeout` configuration prior Java 26, see [JDK-8208693](https://bugs.openjdk.org/browse/JDK-8208693) +* No TLS Proxy support, see [here](https://dev.to/kdrakon/httpclient-can-t-connect-to-a-tls-proxy-118a) +* In case of Proxy TLS tunneling, to enable Proxy Basic authentication, one must use `jdk.http.auth.tunneling.disabledScheme` + Java System Property, see [here](https://docs.oracle.com/en/java/javase/21/core/java-networking.html#GUID-801380C1-4300-4ED8-A390-3C39135267CD). Java versions since 8u111 have this property set to value "Basic" making HTTP + Basic authentication disabled, see [here](https://www.oracle.com/java/technologies/javase/8u111-relnotes.html). To + enable HTTP Basic authentication for Proxy TLS tunneling, one must set `jdk.http.auth.tunneling.disabledScheme` to + empty string, e.g. by adding `-Djdk.http.auth.tunneling.disabledScheme=""` JVM argument. + +Maven 4 uses this transport by default for HTTP(S) protocol. + +## The `apache` (Apache HttpClient) Transport + +Transporter based on Apache HttpClient. + +To use this transporter in Maven 4, you need to specify `-Dmaven.resolver.transport=apache` user property. Review Comment: I think this also lacks SOCKS Proxy support... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
