olamy commented on code in PR #447:
URL:
https://github.com/apache/maven-build-cache-extension/pull/447#discussion_r2801326868
##########
src/test/java/org/apache/maven/buildcache/LifecyclePhasesHelperTest.java:
##########
@@ -22,6 +22,7 @@
import java.util.Arrays;
import java.util.List;
+import com.google.common.collect.Lists;
Review Comment:
Another dependency we do not need.
##########
src/test/java/org/apache/maven/buildcache/LifecyclePhasesHelperTest.java:
##########
@@ -295,7 +296,7 @@ void testPostCachedSegment() {
List<MojoExecution> notCachedSegment =
lifecyclePhasesHelper.getPostCachedSegment(projectMock,
mojoExecutions, build);
- assertThat(notCachedSegment).containsExactly(test, install);
+ assertIterableEquals(Lists.newArrayList(test, install),
notCachedSegment);
Review Comment:
Arrays.asList avoid extra dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
