kwin commented on code in PR #1033:
URL: https://github.com/apache/maven-doxia/pull/1033#discussion_r2809730696
##########
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##########
@@ -1120,6 +1120,18 @@ public void inline(SinkEventAttributes attributes) {
endMarkups.add(BOLD_END_MARKUP);
}
}
+ // <del> is supported via GFM strikethrough extension
+ if
(attributes.containsAttributes(SinkEventAttributeSet.Semantics.DELETE)
+ ||
attributes.containsAttributes(SinkEventAttributeSet.Semantics.LINE_THROUGH)
+ ||
attributes.containsAttributes(SinkEventAttributeSet.LINETHROUGH)) {
Review Comment:
@michael-o Is you concern related to those conditions? So should only
`SinkEventAttributeSet.Semantics.DELETE` lead to this markup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
