rmannibucau commented on code in PR #619:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/619#discussion_r2815989625
##########
doxia-site-model/src/main/mdo/site.mdo:
##########
@@ -653,5 +662,37 @@ under the License.
</field>
</fields>
</class>
+
+ <class java.clone="deep">
+ <name>MermaidConfiguration</name>
+ <description>The configuration used for rendering Mermaid diagrams
(https://mermaid.js.org/) on client-side.</description>
+ <version>2.1.0+</version>
+ <fields>
+ <field xml.attribute="true">
+ <name>externalJsUrl</name>
+ <description>The URL from which to request the Mermaid.js used for
rendering the diagrams. If not set an embedded version of Mermaid is used
(which is automatically deployed to the site).</description>
Review Comment:
not against, I'm used to the free style since otherwise you do what you
propose, ie design some well known attributes and have an open section for
everything "else" and often the else is bypassed cause it doesn't sense when
you start using it to mix rigid and open style configuration but it would work,
it is just more complex to use IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
