elharo commented on code in PR #1524: URL: https://github.com/apache/maven-site/pull/1524#discussion_r2824277337
########## content/markdown/guides/introduction/introduction-to-repositories.md: ########## @@ -68,9 +68,9 @@ While this is possible for any type of remote repository, you must have the perm When using Maven, particularly in a corporate environment, connecting to the internet to download dependencies is not acceptable for security, speed or bandwidth reasons. For that reason, it is desirable to set up an internal repository to house a copy of artifacts, and to publish private artifacts to. -Such an internal repository can be downloaded using HTTP or the file system (with a `file://` URL), and uploaded to using SCP, FTP, or a file copy. +Such an internal repository can be downloaded using HTTPS or the file system (with a `file://` URL), and uploaded to using SCP, SFTP, or a file copy. -As far as Maven is concerned, there is nothing special about this repository: it is another **remote repository** that contains artifacts to download to a user's local cache, and is a publish destination for artifact releases. +As far as Maven is concerned, there is nothing special about this repository: it is another **remote repository** that contains artifacts to download to a user's local cache, and is a destination for publishing artifact releases. Review Comment: is a destination for publishing artifact releases --> to which artifacts can be published ########## content/markdown/guides/introduction/introduction-to-repositories.md: ########## @@ -26,7 +26,7 @@ A repository in Maven holds build artifacts of varying types. There are exactly two types of repositories: **local** and **remote**: 1. the **local** repository is a directory on the computer where Maven runs. It caches remote downloads and contains temporary build artifacts that you have not yet released. -2. **remote** repositories refer to any other type of repository, accessed by a variety of protocols such as `file://` and `https://`. These repositories might be a truly remote repository set up by a third party to provide their artifacts for downloading (for example, [repo.maven.apache.org](https://repo.maven.apache.org/maven2/)). Other "remote" repositories may be internal repositories set up on a file or HTTP server within your company, used to share private artifacts between development teams and for releases. +2. **remote** repositories refer to any other type of repository, accessed by a variety of protocols such as `file://` and `https://`. These repositories might be a truly remote repository set up by a third party to provide their artifacts for downloading (for example, [repo.maven.apache.org](https://repo.maven.apache.org/maven2/)). Other "remote" repositories may be internal repositories set up on a file or HTTPS server within your company, used to share private artifacts between development teams and for releases. Review Comment: in practice these things seem to be called HTTP servers even if they're using HTTPS ########## content/markdown/guides/introduction/introduction-to-repositories.md: ########## @@ -68,9 +68,9 @@ While this is possible for any type of remote repository, you must have the perm When using Maven, particularly in a corporate environment, connecting to the internet to download dependencies is not acceptable for security, speed or bandwidth reasons. For that reason, it is desirable to set up an internal repository to house a copy of artifacts, and to publish private artifacts to. -Such an internal repository can be downloaded using HTTP or the file system (with a `file://` URL), and uploaded to using SCP, FTP, or a file copy. +Such an internal repository can be downloaded using HTTPS or the file system (with a `file://` URL), and uploaded to using SCP, SFTP, or a file copy. Review Comment: it's usually an artifact being downloaded, not the whole repository -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
