elharo commented on code in PR #1232:
URL:
https://github.com/apache/maven-site-plugin/pull/1232#discussion_r2836214548
##########
src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java:
##########
@@ -147,20 +147,20 @@ public Sink createSink(File outputDirectory, String
outputName) {
@Override
public Sink createSink(File arg0, String arg1, String arg2) throws
IOException {
Review Comment:
50/50. It would help to know what we're overriding when throwing an
UnsupportedOperationException. And also the current code is borderline
unreviewable without that info. As is, I'm not sure I understand this well
enough to approve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
