daniel-mohedano opened a new pull request, #3269: URL: https://github.com/apache/maven-surefire/pull/3269
# Details Improvement to <https://github.com/apache/maven-surefire/pull/3241> with null guard before setting the context map in `ThreadedStreamConsumer$Pumper`. `MDC.getCopyOfContextMap()` [is documented](https://www.slf4j.org/api/org/slf4j/MDC.html#getCopyOfContextMap()) as able to return `null` values, while `MDC.setContextMap()` only supports nulled arguments since SLF4J version 2.0.0 When using an adapter conforming to a previous version (for example, [Logback](https://github.com/qos-ch/logback/commit/7e3e2ae770) <1.4.2), this can cause an NPE, killing the `Pumper` daemon thread. # Checklist Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
