olamy commented on code in PR #3312:
URL: https://github.com/apache/maven-surefire/pull/3312#discussion_r2902619464
##########
surefire-api/src/main/java/org/apache/maven/surefire/api/report/CategorizedReportEntry.java:
##########
@@ -155,6 +155,14 @@ public String getNameWithGroup() {
public String getReportNameWithGroup() {
String sourceText = getSourceText();
+ if (isBlank(sourceText)) {
+ sourceText = getName();
+ }
+
+ if (isBlank(sourceText)) {
+ sourceText = getSourceName();
+ }
Review Comment:
well yes and no.
It looks this Test class was not running in our build
https://github.com/apache/maven-surefire/blob/9c1d337ad902809598574efe9272340b31633424/surefire-api/src/test/java/org/apache/maven/surefire/api/report/CategorizedReportEntryTest.java
so never really show any failure due to changes...
Now while migrating to Junit 5 I have reactivated this class and I fixed it
**BUT** now some ITs are failing because of this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
