nielsbasjes opened a new pull request, #11770: URL: https://github.com/apache/maven/pull/11770
@cstamas Followup of this discussion on Slack https://the-asf.slack.com/archives/C7Q9JB404/p1773056234905829?thread_ts=1773053661.648449&cid=C7Q9JB404 When people write in (for example) the maven-invoker-plugin something like `invoker.toolchain.jdk.version = 11` it is implemented as an exact match on the mentioned version specified in the toolchains.xml . Historically people would write this config manually and then the exact version `11` works as expected. With the automatic generation of the toolchains.xml more places will contain the `full` version of the JDK like `<version>11.0.29</version>` instead of the more simple `<version>11</version>`. The effect of people using these automatically generated toolchains.xml files is that now things still work as designed, but not as expected. This is a quick implementation of my proposal to simply treat the requirement of a single number X as "the major version must be X". I have also included the same for a "major.minor" requirement to accept all patch versions under that also. This means a change from a mismatch to a match in cases like this: ``` matcher = RequirementMatcherFactory.createVersionMatcher("1.5.2"); matcher.matches("1.5"); ``` **I'm unsure if this change is "too breaking" to be implemented.** Following this checklist to help us incorporate your contribution quickly and easily: - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - [x] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
