sparsick commented on code in PR #3313:
URL: https://github.com/apache/maven-surefire/pull/3313#discussion_r2918453083


##########
maven-surefire-plugin/src/site/markdown/architecture.md:
##########
@@ -199,36 +223,67 @@ public interface SurefireProvider {
 
 ### Provider implementations
 
-| Provider | Module | Test framework | Key classes |
-|----------|--------|---------------|-------------|
-| **JUnit 3 + POJO** | `surefire-junit3` | JUnit 3.x, plain POJOs | 
`JUnit3Provider`, `PojoTestSetExecutor` |

Review Comment:
   I would not delete the table, but move it to subchapter 3.5



##########
maven-surefire-plugin/src/site/markdown/architecture.md:
##########


Review Comment:
   I would change providers (plural) to junit platform provider (single)



##########
maven-surefire-plugin/src/site/markdown/architecture.md:
##########


Review Comment:
   I think with the change in 3.6.x we will not have dedicated provider module 
for each test framework.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to