HannesWell commented on code in PR #148:
URL:
https://github.com/apache/maven-toolchains-plugin/pull/148#discussion_r2919981958
##########
src/main/java/org/apache/maven/plugins/toolchain/jdk/SelectJdkToolchainMojo.java:
##########
@@ -255,7 +255,7 @@ private boolean matches(String key, String reqVal, String
tcVal) {
case VERSION:
return
RequirementMatcherFactory.createVersionMatcher(tcVal).matches(reqVal);
case ENV:
- return reqVal.matches("(.*,|^)\\Q" + tcVal + "\\E(,.*|$)");
+ return tcVal.matches("(.*,|^)\\Q" + reqVal + "\\E(,.*|$)");
Review Comment:
Yes, I already wanted to add one.
But I found only one very basic test for this at all and setting up a
complete new test infrastructure for this was a bit too much work for me at the
moment. :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
