nielsbasjes commented on PR #11786:
URL: https://github.com/apache/maven/pull/11786#issuecomment-4045549036

   > > * "11+" (unsure what this did) is now "contained in `[11,)`" (as per 
doco)
   > > * "11-" (unsure what this did) is now "contained in `(,11)`" (as per 
doco)
   > 
   > I have to admit that I wasn't aware this notation is possible and maybe 
for others it's the same. And since this 'style' is not common in Maven, I want 
to ask the basic question if it's really worth the effort to support it, also 
with respect to the questions of older Java versions from [#11786 (comment)]
   
   I have only seen this notation in the invoker plugin where you can use this 
for the invoker.properties to specify a need for a specific java version to be 
active to run a specific integration test. I hit my head around this a week ago 
because this syntax is bot supported for the requested toolchain in the same 
file regarding the same kind of requirement.
   
   From my perspective I would 
   - Make the matching consistent across all places where you can do version 
matching like this.
   - Have a specific one for java/jdk versions where the "1.8"/"8" issue is 
handled.
   - Isolate the "+"/"-" syntax of the invoker plugin purely to that plugin and 
make it simply translate that syntax into something like '[11,)' / '(,11)' and 
send it to the generic code from there. Also give a deprecation warning message 
in the output if this is used.
   - A few versions later drop this old syntax from invoker and then the syntax 
is consistent across the plugins.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to