cstamas commented on PR #1554: URL: https://github.com/apache/maven-mvnd/pull/1554#issuecomment-4067875795
Hm, thinking and few remarks: * The `source-distribution` profile is used in conjunction with `-N` CLI option, so only "top module" is invoked to build source distribution. * Why not just add `<inherited>false</inherited>` to plugin? The change in this PR would still invoke the plugin, but the plugin logic would decide to return without doing anything (waste of cycles), while with `inherited=false` the plugin would not be invoked at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
