gnodet commented on PR #1514: URL: https://github.com/apache/maven-mvnd/pull/1514#issuecomment-4073080471
Thanks for the contribution @janweinschenker! The idea of making the completion script work in both bash and zsh is great. I've opened #1559 which takes a slightly different approach: instead of adding a second script file, it modifies the existing `mvnd-bash-completion.bash` template in-place to auto-detect the shell. This keeps a single script to maintain and integrates with the existing generation pipeline (`CompletionGeneratorTest`). Key differences from this PR: - Single file (no duplication with the existing bash script) - Goes through the template so the generator keeps working - No global `setopt` calls that could affect user shell preferences - No redundant `compinit` (only `bashcompinit` which is needed) - `Completion.java` updated to accept `--completion zsh` - README updated instead of a separate `.adoc` file You're credited as co-author on the commit. Would you mind testing #1559 in your zsh environment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
