sparsick commented on code in PR #3332: URL: https://github.com/apache/maven-surefire/pull/3332#discussion_r2987651813
########## maven-surefire-plugin/src/site/markdown/architecture.md: ########## @@ -30,7 +30,7 @@ Apache Maven Surefire is the test execution framework for Maven. It ships three | **maven-failsafe-plugin** | Runs integration tests during `integration-test` / `verify` phases | | **maven-surefire-report-plugin** | Generates HTML test reports from XML results | -Surefire supports JUnit 3, JUnit 4, JUnit 5 (Jupiter), TestNG, and plain POJO tests. <br/> +Surefire supports JUnit 4 (4.12+), JUnit 5 (Jupiter), and TestNG (6.14.3+). <br/> Review Comment: We should mention JUnit 6 explicitly, like JUnit5/6 ########## maven-surefire-plugin/src/site/markdown/architecture.md: ########## @@ -443,16 +439,16 @@ The `maven-surefire-report-plugin` reads the XML files (via `surefire-report-par ## Group / Category Filtering -The `surefire-grouper` module provides test filtering by JUnit 4 categories or TestNG groups. +Since 3.6.0, test filtering by groups, categories, or tags is handled via the JUnit Platform's native **tag expression** syntax. ### How it works 1. Users configure `<groups>` and `<excludedGroups>` in the plugin configuration -2. For **JUnit 4.7+**: the `surefire-junit47` provider uses `GroupMatcherCategoryFilter` to filter tests by `@Category` annotations -3. For **TestNG**: groups are passed directly to TestNG's native group filtering -4. For **JUnit Platform**: tag filter expressions are passed to the JUnit Platform Launcher +2. For **JUnit 4**: `@Category` annotations are mapped to JUnit Platform tags via the Vintage Engine +3. For **TestNG**: groups are mapped to JUnit Platform tags via the TestNG Engine +4. For **JUnit 5**: `@Tag` annotations are used natively Review Comment: We should mention JUnit 6 explicitly, like `JUnit5/6` ########## maven-surefire-plugin/src/site/apt/developing.apt.vm: ########## @@ -127,11 +127,9 @@ ForkedBooter#main * Common Provider Modules - The <<<surefire-providers>>> module contains <<<common-junitXX>>> modules. These modules - depend on the <<<XX>>> version of JUnit and can access the JUnit APIs at the correct - JUnit version level. Unit tests can also be written that will run with the - correct JUnit version. At build time, all of the relevant parts of these "common" - modules are just shaded into the provider jar files. + The <<<surefire-providers>>> module contains the <<<common-java5>>> module and the + unified <<<surefire-junit-platform>>> provider. Since 3.6.0, all test frameworks + (JUnit 4.12+, JUnit 5, TestNG 6.14.3+) are executed via the JUnit Platform provider. Review Comment: We should mention JUnit 6 explicitly, like JUnit5/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
