MilanTyagi2004 commented on PR #3329: URL: https://github.com/apache/maven-surefire/pull/3329#issuecomment-4143638898
> @MilanTyagi2004 i am just a regular surefire user, so i can't tell you what you should do to be honest 😅 > > it also kind of depends on the findings with your added test. if you realized that the problem of missing testcases not only happens on junit5 but also on junit4, then we should consider extending the scope of this PR. > > alternatively, we should file a dedicated issue mentioning both junit4 and 5 and then this PR can keep the junit5 scope and we will need to follow-up with a fix and tests for the junit4 cases. > > if your tests found no problems with junit4, you can ignore all my comments and we will need to investigate this separately. > > what this PR is missing even if its only for junit5: > > * fix unrelated reformatting in `surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java` > * add junit5 test that covers exceptions in `@AfterAll`. sure we can discuss the junit4 issues in another pr. for RunListenerAdapter.java changes are needed to pass error to xml. , and i understand but before adding Junit 5 test which cover `@AfterAll` i am waiting for the review from "olamy". Hope you understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
