michael-o commented on code in PR #630:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/630#discussion_r3006573597
##########
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/SiteTool.java:
##########
@@ -129,6 +134,32 @@ SiteModel getSiteModel(
List<RemoteRepository> remoteProjectRepositories)
throws SiteToolException;
+ /**
+ * Get a site model for a project.
+ *
+ * @param siteDirectory the site directory, may be null if project from
repository
+ * @param locale the locale used for the i18n in SiteModel, not null.
+ * See {@link #getSiteDescriptor(File, Locale)} for details.
+ * @param project the Maven project, not null.
+ * @param request the Maven execution request (may be null). This is
needed to get the user properties and the system properties for interpolation.
Review Comment:
When can the request be null?
##########
doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java:
##########
@@ -383,6 +388,7 @@ void getDefaultSiteModel() throws Exception {
SiteModel model = tool.getSiteModel(
new File(project.getBasedir(), siteDirectory),
SiteTool.DEFAULT_LOCALE,
+ new DefaultMavenExecutionRequest(),
Review Comment:
Why, if null is suitable as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
