UtkarshSinghChauhan commented on code in PR #3265:
URL: https://github.com/apache/maven-surefire/pull/3265#discussion_r3001226269
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -456,7 +456,8 @@ private void startTestElement(XMLWriter ppw,
WrappedReportEntry report) throws I
String className = phrasedClassName
? report.getReportSourceName(reportNameSuffix)
- : report.getSourceText() != null ? report.getSourceText() :
report.getSourceName(reportNameSuffix);
+ : report.getSourceName(reportNameSuffix);
Review Comment:
Thanks for pointing this out.
My change does not reintroduce the issue from SUREFIRE-2298.
The goal of this change is to restore reportNameSuffix in the
testcase classname attribute, which was lost after that change.
Using report.getSourceName(reportNameSuffix) still keeps the
correct behavior for JUnit 5 nested classes while restoring
the suffix in the XML report classname.
I will also add an integration test to verify this behavior.
Sorry for the late reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
