kwin commented on PR #325: URL: https://github.com/apache/maven-fluido-skin/pull/325#issuecomment-4164390868
Thanks for this. Would it be possible to have a opt-in toggle for that, i.e. only activate if configured via site descriptor (similar to https://maven.apache.org/skins/maven-fluido-skin/#Source_code_line_numbers)? That probably forces to rely on an additional class which needs to be set on at least one element. Just enabling by default is something we probably shouldn't do in a minor version release of fluido. Also an option to explicitly toggle between light/dark (independent of browser setting, something like on https://jspecify.dev/about/ with the top right icon) would be nice to have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
