slawekjaranowski commented on code in PR #1599:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/1599#discussion_r3204967141


##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -148,4 +153,38 @@ public void setSilent(boolean silent) {
             setLog(new SystemStreamLog());
         }
     }
+
+    /**
+     * Checks whether the dependency exists in the project's declared 
(original) model
+     * after property interpolation, but before inheritance merging.
+     * This catches dependencies declared with property references like {@code 
${project.groupId}}
+     * without false-positiving on inherited dependencies from a parent POM.
+     */
+    protected static boolean existsInResolvedModel(MavenProject project, 
DependencyEntry coords, boolean managed) {

Review Comment:
   I would not like to add a static method to abstract class when it is only 
used in two specific child .... 
   I don't have a good idea for it ... next abstract in level or util class ...
   
   If no better idea can be as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to