hboutemy commented on code in PR #8:
URL: https://github.com/apache/maven-executor/pull/8#discussion_r3244697807
##########
pom.xml:
##########
@@ -23,11 +23,12 @@
<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-parent</artifactId>
- <version>47</version>
+ <version>48</version>
Review Comment:
not related to "Undo GAV change"
##########
maven-executor/src/main/java/org/apache/maven/executor/support/ExecutorHelperImpl.java:
##########
@@ -73,12 +73,14 @@ public String mavenVersion() {
if (closed.get()) {
throw new ExecutorException("Executor is closed");
}
- return cache.computeIfAbsent("maven.version", k -> getExecutor(
- Mode.AUTO,
- ExecutorRequest.mavenBuilder()
-
.userHomeDirectory(ExecutorRequest.discoverUserHomeDirectory())
- .build())
- .mavenVersion());
+ return cache.computeIfAbsent(
+ "maven.version",
+ k -> getExecutor(
+ Mode.AUTO,
+ ExecutorRequest.mavenBuilder()
+
.userHomeDirectory(ExecutorRequest.discoverUserHomeDirectory())
+ .build())
+ .mavenVersion());
Review Comment:
how is that change related to "undo GAV change"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
