gnodet opened a new pull request, #12082:
URL: https://github.com/apache/maven/pull/12082
## Summary
- Migrate `mvnup` from JDOM to domtrip XML API on the `maven-4.0.x` branch,
aligning it with `master`
- Cherry-pick of commit a336a2c579 ("Switch mvnup to domtrip #11432") with
conflict resolution for 4.0.x-specific backport divergence
- Update domtrip version to 0.4.1 (matching master)
This eliminates the need to maintain two separate XML API implementations
for mvnup across branches, enabling clean cherry-picks between `master` and
`4.0.x`.
Fixes #12081
## Changes
- **Root `pom.xml`**: Add domtrip dependency management (0.4.1), remove jdom2
- **`maven-cli/pom.xml`**: Replace jdom2 dependency with domtrip-core +
domtrip-maven
- **Source files removed**: `JDomUtils.java`, `GAV.java`, `GAVUtils.java`,
`UpgradeConstants.java`
- **Source file added**: `DomUtils.java` (domtrip-based XML utilities)
- **All strategy files rewritten**: JDOM API → domtrip API
(CompatibilityFixStrategy, InferenceStrategy, ModelUpgradeStrategy,
ModelVersionUtils, PluginUpgradeStrategy, PomDiscovery, StrategyOrchestrator,
etc.)
- **All test files migrated** accordingly
## Test plan
- [x] All 228 mvnup tests pass
- [x] No JDOM imports remain in `**/mvnup/**` files
- [x] Spotless formatting clean
- [x] Compilation succeeds
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
