gnodet opened a new pull request, #12083:
URL: https://github.com/apache/maven/pull/12083
## Summary
- Add a new compatibility fix to `CompatibilityFixStrategy` that comments
out dependencies with undefined property expressions in their coordinates
(groupId, artifactId, version)
- Collects all properties from `<properties>` sections across the reactor
(including profiles), skips well-known built-ins (`project.*`, `env.*`,
`settings.*`, `maven.*`, `revision`, `sha1`, `changelist`, etc.)
- Uses domtrip's `Editor.commentOutElement()` with a `<!-- mvnup: commented
out - undefined property '...' -->` marker for easy identification and reversal
Fixes #12080
## Test plan
- [x] Unit test: dependency with undefined property gets commented out
- [x] Unit test: dependency with defined property is preserved
- [x] Unit test: dependency with well-known built-in property
(`${project.version}`) is preserved
- [x] Unit test: cross-module property resolution (property defined in
parent POM recognized in child)
- [x] All 13 `CompatibilityFixStrategyTest` tests pass
- [x] Formatter produces no changes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
