Will-thom commented on PR #12069: URL: https://github.com/apache/maven/pull/12069#issuecomment-4524902915
Addressed the review concerns in a follow-up commit: - site detection now uses the requested session goals instead of the producer project's lifecycle state; - synthetic empty JARs are written under a separate `reactor-empty-artifacts` directory instead of `project-local-repo`; - empty artifact creation is cached per target path with `ConcurrentHashMap.computeIfAbsent`, avoiding the previous coarse `synchronized(this)` lock; - the IT now asserts that `site` does not leave a synthetic producer JAR in `target/project-local-repo`. Validation passed locally: ```sh mvn -Dmaven.repo.local=..\maven-12069-m2 -Drat.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=ReactorReader -pl impl/maven-core -am test mvn -Dmaven.repo.local=..\maven-12069-m2 -Drat.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dits.test=MavenITgh12064SiteReactorDependenciesTest -Prun-its -pl its/core-it-suite -am verify ``` The focused IT report shows 1 test, 0 failures, 0 errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
