gnodet opened a new pull request, #12158:
URL: https://github.com/apache/maven/pull/12158
## Summary
- Fix `CompatibilityFixStrategy` incorrectly commenting out
`dependencyManagement` entries whose versions use properties inherited from
remote parent POMs (e.g., `${oak.version}` from `sling-parent`, `${version}`
from a published parent)
- The existing static analysis only scanned reactor POMs for property
definitions, missing properties from remote parents
- Now uses the `buildEffectiveModel` infrastructure (already available in
`AbstractUpgradeStrategy`) to resolve properties from the full parent chain
before deciding a property is "undefined"
Fixes https://github.com/gnodet/maven4-testing/issues/13383
Fixes https://github.com/gnodet/maven4-testing/issues/13374
## Test plan
- [x] New test: property from external parent not in reactor is correctly
recognized as defined
- [x] New test: truly undefined property (not in any parent) is still
correctly commented out
- [x] All 24 existing `CompatibilityFixStrategyTest` tests continue to pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
