gnodet opened a new pull request, #12160: URL: https://github.com/apache/maven/pull/12160
## Summary - **Remove** invalid `combine.self` and `combine.children` attribute values entirely instead of converting them to `merge`, since Maven 3 silently ignored invalid values — removing preserves actual Maven 3 behavior - Detect **any** invalid value against the full set of valid values (`combine.self`: `override`/`merge`/`remove`; `combine.children`: `append`/`merge`), not just specific ones like `append` or `override` - Collect matching elements to a list before mutating, replacing the `.peek().count()` pattern which could miss occurrences ## Test plan - [x] Added tests for removing `combine.self="append"` and arbitrary invalid values - [x] Added tests for removing `combine.children="override"` and arbitrary invalid values - [x] Added tests verifying valid values (`override`, `merge`, `remove` for self; `append`, `merge` for children) are preserved - [x] Added tests for invalid attributes in profile plugin configurations - [x] Added tests for all occurrences across pluginManagement, plugins, and profiles - [x] All 31 CompatibilityFixStrategyTest tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
