gnodet opened a new pull request, #12177:
URL: https://github.com/apache/maven/pull/12177
## Summary
- Fix inconsistent property source in `DefaultModelBuilder` that caused
`${revision}` to not be properly interpolated in dependency versions and
distributionManagement when user properties differ between the
`ModelBuilderRequest` and the `Session`
- Fix `DefaultConsumerPomBuilder` to use API Session properties instead of
`RepositorySystemSession` properties for consumer POM model building
- Add tests for CI-friendly `${revision}` interpolation in dependency
versions with model properties, user property overrides, and user-property-only
scenarios
## Context
The model builder used `session.getEffectiveProperties()` /
`session.getUserProperties()` for CI-friendly version replacement and model
property merging, while model interpolation used `request.getUserProperties()`.
These can diverge when a `ModelBuilderRequest` is created with custom user
properties. The fix makes all property lookups use request properties
consistently.
## Test plan
- [x] `DefaultModelBuilderTest` — 3 new tests for `${revision}` in
dependency versions and distributionManagement
- [x] `DefaultModelBuilderTest` — all 9 tests pass
- [x] `maven-impl` — all 471 tests pass
- [x] `maven-core` — all 546 tests pass (1 pre-existing skip)
- [x] `maven-compat` — all 160 tests pass (7 pre-existing skips)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
