hboutemy commented on PR #466: URL: https://github.com/apache/maven-resources-plugin/pull/466#issuecomment-4586205844
MRESOURCE-18 issue fixed by https://github.com/apache/maven-resources-plugin/pull/477/changes#diff-992d499701077cf9c8d6a4f126bb4ec7a2fd884a2202a81a9cca9310fc89c234 now remaining issue is: ``` [INFO] ------------------------------------------------- [INFO] Build Summary: [INFO] Passed: 26, Failed: 1, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------- Error: The following builds failed: Error: * user-filters/pom.xml [INFO] ------------------------------------------------- ``` with ``` Running post-build script: /Users/runner/work/maven-resources-plugin/maven-resources-plugin/target/it/user-filters/verify.groovy Assertion failed: assert content.contains( 'toto=titi') | | | false 'foo\nversion=1.0.16-SNAPSHOT\ntoto=null\n' ``` user filter does not work https://github.com/apache/maven-resources-plugin/blob/maven-resources-plugin-3.x/src/test/java/org/apache/maven/plugins/resources/filters/ItFilter.java#L71 ```java lines.add("toto=" + mavenResourcesExecution .getMavenSession() .getSystemProperties() .getProperty("toto")); ``` system properties? could that be a change in Maven 4 vs 3 that explains the difference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
