gnodet opened a new pull request, #12204:
URL: https://github.com/apache/maven/pull/12204
## Summary
- Extends `mvnup` compatibility fix to comment out `<repository>` and
`<pluginRepository>` elements whose `<id>` or `<url>` contain undefined
property expressions (e.g. `${eclipseP2RepoId}`)
- Follows the same pattern as #12080 which comments out dependencies with
undefined expressions
- Handles both root-level and profile-level repositories/pluginRepositories
## Context
Projects like uima-uimaj, opennlp-sandbox, and seatunnel-shade define
repositories with `${eclipseP2RepoId}` in the repo ID. This property is never
defined — it was used as a literal string in Maven 3 (which silently accepted
it). Maven 4 rejects it at runtime with `IllegalArgumentException: Not fully
interpolated remote repository`.
Rather than silently filtering these repos at runtime (which could mask real
resolution problems), `mvnup` now proactively fixes the POM by commenting out
the problematic repos during migration.
## Test plan
- [x] Unit tests for commenting out repos with undefined property in ID
- [x] Unit tests for commenting out repos with undefined property in URL
- [x] Unit tests for preserving repos with defined properties
- [x] Unit tests for commenting out plugin repositories
- [x] Unit tests for preserving repos with well-known properties
(`${project.basedir}`, etc.)
_Claude Code on behalf of Guillaume Nodet_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
