cstamas commented on PR #1902: URL: https://github.com/apache/maven-resolver/pull/1902#issuecomment-4649043658
Overall looks good, but there are IMHO some unnecessary usage of `volatile` (not biggie, but anyone seeing this keyword may frantically look for "where is this concurrently used?" and maybe find nothing), and similarly for `synchronized`. Latter even slows down things in case of true single threaded run, no? (ie obtaining object monitor...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
