elharo commented on code in PR #522:
URL: https://github.com/apache/maven-jar-plugin/pull/522#discussion_r3409431347
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -297,6 +306,15 @@ public File createArchive() throws MojoExecutionException {
boolean containsModuleDescriptor =
Arrays.stream(includedFiles).anyMatch(p ->
p.endsWith(MODULE_DESCRIPTOR_FILE_NAME));
+ if (automaticModuleName != null && !automaticModuleName.isEmpty()) {
+ if (containsModuleDescriptor) {
+ getLog().warn("Not setting automatic module name, because a
module descriptor was found.");
Review Comment:
I don't think this should have log messages. Having a module descriptor
should not cause a warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
