ascheman opened a new pull request, #12298:
URL: https://github.com/apache/maven/pull/12298
Hypersedes #12297 (which superseded #12291).
Starts from the head of #12297 and adds one additional integration
test, `testActiveByDefaultDeactivatedViaCli`, that guards the
`-P !profileId` deactivation path introduced in @gnodet's commit
"Address review feedback: fix activeByDefault deactivation and rename
IT". The fix logic itself is unchanged from #12297; this PR adds the
regression test to lock it in.
## What's new vs #12297
* `testActiveByDefaultDeactivatedViaCli` — runs `mvn install` with
`-P!aether-split-via-settings` and asserts the artifact lands at the
flat layout (not under the custom prefix), confirming the
`inactiveProfileId` guard works end-to-end.
* `deleteRecursivelyIfExists` private helper — clears any stale
`it-custom-prefix/` subtree before the deactivation run, so the
assertion is robust against test-execution order with sibling tests
installing under that same prefix.
## Verification
* Patched build: 3/3 ITs green.
* Without the deactivation guard in the fix (i.e. vanilla master):
`testActiveByDefaultProfile` is RED — the bug — and the deactivation
test trivially passes because the profile is silently dropped anyway.
So the new test specifically guards the fix-introduced deactivation
logic, not a pre-existing path.
Happy to fold the extra test into #12297 instead if you'd prefer to
keep it on a single PR; just say the word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
