ascheman opened a new pull request, #668:
URL: https://github.com/apache/maven-deploy-plugin/pull/668
Builds master green on Maven 4 rc-5. Stacks two existing rc-5 efforts and
adds
the small classpath fix that was missing from the first attempt.
## Commits
1. **Failing to update to rc5** — cherry-pick of #632 (`f801ee5`, @Bukama).
Bumps `mavenVersion` and the CI workflow's `maven4-version` from rc-3 to
rc-5, plus `Version.asString()` → `toString()` in `DeployFileMojo` for
the API change in rc-5.
2. **update deployAtEnd ITs to match latest 4 behaviour** — cherry-pick of
`bed4d62` (@hboutemy, from the `maven4-enabled` branch). Teaches the
MDEPLOY-224 / MDEPLOY-225 `verify.groovy` scripts about Maven 4's
"deploy at root target" behaviour.
3. **work around Maven 4 CLI lack of interpolation** — cherry-pick of
`dd96008` (@hboutemy, from #655 on the 3.x line, applies here too).
Rewrites the `deploy-file` IT property fixtures to relative paths,
since Maven 4's invoker sub-builds no longer interpolate
`${project.basedir}` / `${project.artifactId}` / `${project.version}`
inside `invoker.properties`.
4. **Pin maven-xml to ${mavenVersion} for the test classpath** — fixes the
`XmlService$Holder.<clinit>` `NoClassDefFoundError` @Bukama documented
on #632. `maven-plugin-testing-harness:4.0.0-beta-4` transitively pins
`maven-xml` to rc-3 and pulls in `maven-xml-impl:4.0.0-alpha-9` (an
artifactId removed at rc-4 — the SPI provider now lives inside
`maven-xml` itself). Pinning `maven-xml` to `${mavenVersion}` in
`dependencyManagement` puts a matching provider on the unit-test
classpath.
## Verification
`mvn -P run-its clean verify` on Apache Maven 4.0.0-rc-5 / JDK 17:
**42 passed / 0 failed**.
References #632.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
