gnodet opened a new pull request, #12324:
URL: https://github.com/apache/maven/pull/12324

   ## Summary
   
   - The `its/core-it-suite/pom.xml` pluginManagement override for 
`spotless-maven-plugin` only specified `<includes>` and `<excludes>`, which 
inadvertently wiped out the formatting steps (`palantirJavaFormat`, 
`removeUnusedImports`, `importOrder`, `licenseHeader` for Java; `sortPom` for 
POM).
   - The `its/` parent chain inherits from `apache:38` (not `maven-parent:48` 
where these steps are defined), so there was no parent config to inherit — 
`combine.children="append"` alone could not fix this.
   - Added the formatting steps explicitly along with the 
`maven-shared-resources` dependency (needed for `importOrder` and 
`licenseHeader` config files), and applied formatting to all files in the 
module.
   
   ## Test plan
   
   - [x] `mvn -B com.diffplug.spotless:spotless-maven-plugin:check -f 
its/core-it-suite` passes
   - [x] Verified formatting is enforced by creating a deliberately badly 
formatted file and confirming spotless catches it
   - [ ] CI passes
   
   _Claude Code on behalf of Guillaume Nodet_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to