tfactor2 commented on PR #498: URL: https://github.com/apache/maven-build-cache-extension/pull/498#issuecomment-4793253365
Why `saveDirectoryArtifact(...)` is removed: The method made a directory-backed Maven project artifact saveable by zipping it and storing it through the main artifact path. That preserved the invalid metadata shape that caused #449: `target/classes` is a compile output directory, not the project's packaged main artifact. With this change, `saveProjectArtifact(...)` only saves regular files produced by package-or-later mojos. Compile outputs are still cached, but through `attachCompileOutputs(...)` / attached output archives, so jar modules keep compile-cache benefits without letting `target/classes` poison later `package` or `install` executions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
