ascheman opened a new pull request, #271:
URL: https://github.com/apache/maven-gh-actions-shared/pull/271

   ## Problem
   
   The `Set up Maven` step bootstraps the Maven wrapper by running the runner's
   *system* `mvn` against `maven-wrapper-plugin:wrapper`:
   
   ```yaml
   - name: Set up Maven
     run: mvn … maven-wrapper-plugin:3.3.4:wrapper "-Dmaven=${{ matrix.maven }}"
   ```
   
   Running any goal in a project directory forces Maven to read the project 
model,
   which includes **resolving the parent POM** — even though the goal itself 
only
   writes wrapper files. This step does **not** pass `${{ inputs.maven-args }}`,
   unlike the later `Build with Maven` / `Build Maven Site` steps.
   
   So a caller that injects a custom settings file via `maven-args`
   (e.g. `-s .github/settings.xml` to reach a *staged* Apache parent POM during 
a
   simultaneous Apache-parent / project-parent vote) cannot influence parent
   resolution in this first step. The bootstrap then fails with
   `Non-resolvable parent POM … org.apache:apache:pom:39 … in central` before 
the
   actual build ever runs.
   
   Concrete failure: apache/maven-parent#578 →
   
https://github.com/apache/maven-parent/actions/runs/28279903879/job/83793460535
   
   ## Fix
   
   Pass `${{ inputs.maven-args }}` to the wrapper bootstrap in both the
   `fail-fast-build` and `verify` jobs. The default value
   (`-D"invoker.streamLogsOnFailures"`) is benign, so this is a no-op for 
callers
   that do not set `maven-args`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to