[
http://jira.codehaus.org/browse/SUREFIRE-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Bentmann updated SUREFIRE-259:
---------------------------------------
Attachment: SUREFIRE-259.zip
Steps to make it fail:
# unpack the attached mini project
# get yourself a Windows box to test it on
# cd into the project base directory
# run "mvn test"
# run "mvn jxr:test-jxr surefire-report:report-only"
# browse to the surefire report and try to follow the hyperlink to the failed
test "BasicTest"
bq. The main problem with it being a string is that it becomes os dependant
Dan, that's the point you need take into mind. The linking fails because
determineXrefLocation() feeds PathTool.getRelativePath() with the following
parameters:
{noformat}
basedir = ${basedir}/target/site
filename = ${basedir}\target\site\subdir\xref-test
{noformat}
Note the different file separators. Due to these, the check
filename.startsWith( basedir ) in PathTool fails and the method quits
immediately, errorneously reporting the relative path as "".
> Calculation of relative path to xref is wrong
> ---------------------------------------------
>
> Key: SUREFIRE-259
> URL: http://jira.codehaus.org/browse/SUREFIRE-259
> Project: Maven Surefire
> Issue Type: Bug
> Components: report plugin
> Affects Versions: 2.0 Report Plugin
> Environment: WinXp, Java5
> Reporter: Martin Zeltner
> Fix For: 2.x
>
> Attachments:
> patch_maven-surefire-report-plugin_relative-path-to-xref.patch,
> patch_maven-surefire-report-plugin_relative-path-to-xref_2.patch,
> SUREFIRE-259.zip
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> The calculation of the relative path to xref is wrong! I.e. it fails with the
> current config:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-report-plugin</artifactId>
> <version>2.1-SNAPSHOT</version>
> <configuration>
> <linkXRef>true</linkXRef>
> <xrefLocation>target/site/framework-tests/xref</xrefLocation>
> <outputDirectory>target/site</outputDirectory>
> </configuration>
> </plugin>
> In appended patch I've changed the following:
> * Parameter outputDirectory is now a java.io.File so there is even a
> chance to find out the relavtive path for the config above.
> * I've replaced the code where the relative path is calculated with the
> static method invocation of my new util class (tests for util class included).
> Cheers,
> Martin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
